Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 7636: Proof Key for Code Exchange #409

Merged
merged 2 commits into from Sep 13, 2019
Merged

RFC 7636: Proof Key for Code Exchange #409

merged 2 commits into from Sep 13, 2019

Conversation

@adaxi
Copy link
Contributor

adaxi commented May 2, 2019

PKCE (RFC 7636) is a technique to secure public clients that don't use a client secret.

It is primarily used by native and mobile apps, but the technique can be applied to any public client as well.

Although hapi and bell are usually used in places where a secret can be kept safely, someone might be using it as a public client.

My motivation for this pull request is not because my application is public, but because I am using a provider which requires PKCE.

More information:
https://oauth.net/2/pkce/
https://www.oauth.com/oauth2-servers/pkce/
https://www.oauth.com/oauth2-servers/pkce/authorization-request/

PKCE (RFC 7636) is a technique to secure public clients that don't
use a client secret. It is primarily used by native and mobile apps,
but the technique can be applied to any public client as well.
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 2, 2019

Interesting. I'll try to get to it next couple of weeks.

@adaxi

This comment has been minimized.

Copy link
Contributor Author

adaxi commented Jun 3, 2019

bump.

@hueniverse hueniverse self-assigned this Sep 13, 2019
@hueniverse hueniverse added the feature label Sep 13, 2019
@hueniverse hueniverse added this to the 11.0.0 milestone Sep 13, 2019
@hueniverse hueniverse merged commit 0a0440c into hapijs:master Sep 13, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
hueniverse added a commit that referenced this pull request Sep 13, 2019
@hueniverse hueniverse mentioned this pull request Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.