Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github login example #416

Merged
merged 2 commits into from Sep 13, 2019
Merged

Update github login example #416

merged 2 commits into from Sep 13, 2019

Conversation

@Death-Gear
Copy link
Contributor

Death-Gear commented Jul 25, 2019

Proposed Changes

  • Added comment helping developers set up a github app for generating ID and secret
  • isSecure option added

Reasons

  • The comment can help users set up a github app.
  • isSecure must be set to false to remove the TLS requirement.
Death-Gear and others added 2 commits Jul 25, 2019
@hueniverse hueniverse self-assigned this Sep 13, 2019
@hueniverse hueniverse added the example label Sep 13, 2019
@hueniverse hueniverse added this to the 11.0.0 milestone Sep 13, 2019
@hueniverse hueniverse merged commit 679287a into hapijs:master Sep 13, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@Marsup Marsup added documentation and removed example labels Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.