Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump peer dependency to Hapi >= 6 #5

Merged
merged 1 commit into from Jun 12, 2014
Merged

Conversation

@bradobro
Copy link

bradobro commented Jun 12, 2014

Yesterday I thought I'd convert our Hapi 4.1 app (held there by Travelogue) over to Bell. A glance at the peerDependencies made me think this was a good idea. peerDependencies handling in npm isn't solid, but Bell definitely needs Hapi >= 6 because of server.location() in oauth.js.

This is just a proposal that the README.md or package.json indicate that.

Thanks for spearheading this, @hueniverse.It solves a lot of annoyances we've had with OAuth frameworks.

Brad Olson
@hueniverse hueniverse added the bug label Jun 12, 2014
@hueniverse hueniverse added this to the 1.0.1 milestone Jun 12, 2014
@hueniverse hueniverse self-assigned this Jun 12, 2014
hueniverse added a commit that referenced this pull request Jun 12, 2014
Bump peer dependency to Hapi >= 6
@hueniverse hueniverse merged commit 23f483c into hapijs:master Jun 12, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.