Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinkedIn provider #69

Merged
merged 1 commit into from Apr 3, 2015
Merged

Add LinkedIn provider #69

merged 1 commit into from Apr 3, 2015

Conversation

@robertd
Copy link
Contributor

robertd commented Apr 2, 2015

Credits go to @mkoskine for initial implementation in #64.
I just cleaned few things up...

Cheers!

@geek geek added the feature label Apr 3, 2015
@geek geek added this to the 2.3.0 milestone Apr 3, 2015
@geek geek self-assigned this Apr 3, 2015
scope: ['r_fullprofile', 'r_emailaddress', 'r_contactinfo'],
scopeSeparator: ',',
profile: function (credentials, params, get, callback) {
var query = {

This comment has been minimized.

Copy link
@geek

geek Apr 3, 2015

Member

we have a different style guide. I'll update the linting rules at some point... but please add a newline after every function declaration. The reason is to make it easier to identify new scopes

This comment has been minimized.

Copy link
@robertd

robertd Apr 3, 2015

Author Contributor

will do

};

get('https://api.linkedin.com/v1/people/~', query, function (profile) {
credentials.profile = {

This comment has been minimized.

Copy link
@geek

geek Apr 3, 2015

Member

please add a newline

@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 3, 2015

Looks good overall... just a couple of minor changes and need to pull the latest from master so it can be merged. Thanks!

@robertd robertd force-pushed the robertd:linkedin-provider branch 2 times, most recently from 04d1dbb to 304a217 Apr 3, 2015
@robertd

This comment has been minimized.

Copy link
Contributor Author

robertd commented Apr 3, 2015

Let me know if there are any more styling discrepancies...

Thanks

edit: forgot to mention that I've rebased of of latest master

* Changed access premission 644 -> 755 for dropbox.js, bitbucket.js and
instagram.js to match others
@robertd robertd force-pushed the robertd:linkedin-provider branch from 304a217 to cbadb3f Apr 3, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 3, 2015

@robertd so fast! Nicely done.

@robertd

This comment has been minimized.

Copy link
Contributor Author

robertd commented Apr 3, 2015

squashed too ... just in case :)

geek added a commit that referenced this pull request Apr 3, 2015
Add LinkedIn provider
@geek geek merged commit 12346b5 into hapijs:master Apr 3, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek geek mentioned this pull request Apr 3, 2015
@robertd robertd deleted the robertd:linkedin-provider branch Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.