Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Phabricator #77

Merged
merged 4 commits into from Apr 22, 2015
Merged

Support for Phabricator #77

merged 4 commits into from Apr 22, 2015

Conversation

@hofan41
Copy link
Contributor

hofan41 commented Apr 16, 2015

Added support for third party installations of phabricator, the user must supply a URI in the config options in order for it to work.

Closes #75

@geek geek added the feature label Apr 20, 2015
@geek geek self-assigned this Apr 20, 2015
@geek geek added this to the 2.3.1 milestone Apr 20, 2015
scope: ['whoami'],
scopeSeparator: ',',
profile: function (credentials, params, get, callback) {
var query = {

This comment has been minimized.

Copy link
@geek

geek Apr 20, 2015

Member

we add a newline after function declarations. please update the PR with the newlines. Here is more detail on the styleguide: hapijs.com/styleguide


expect(err).to.not.exist();

expect( function() {

This comment has been minimized.

Copy link
@geek

geek Apr 20, 2015

Member

expect(function () {

This comment has been minimized.

Copy link
@geek

geek Apr 20, 2015

Member

you can rewrite as

expect(Bell.providers.phabricator).to.throw(Error); <-- I think

This comment has been minimized.

Copy link
@hofan41

hofan41 Apr 21, 2015

Author Contributor

I dig that. Updating now!

Added new lines after function declarations.
Simplified unit test expect call.
geek added a commit that referenced this pull request Apr 22, 2015
Support for Phabricator
@geek geek merged commit 7f4e360 into hapijs:master Apr 22, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.