Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Reddit as an OAuth provider #80

Merged
merged 3 commits into from May 1, 2015
Merged

Support Reddit as an OAuth provider #80

merged 3 commits into from May 1, 2015

Conversation

@geuis
Copy link

geuis commented Apr 29, 2015

Additionally enables basic http authentication header as required from reddit for oauth2 to function.

…der as required for reddit oauth
@geek geek added the feature label Apr 29, 2015
@geek geek self-assigned this Apr 29, 2015
@geek geek added this to the 2.4.1 milestone Apr 29, 2015
@geek geek changed the title add reddit as oauth provider Adding Reddit as OAuth provider Apr 29, 2015
@geek geek changed the title Adding Reddit as OAuth provider Support Reddit as OAuth provider Apr 29, 2015
@geek geek changed the title Support Reddit as OAuth provider Support Reddit as an OAuth provider Apr 29, 2015


exports = module.exports = function (options) {
return {

This comment has been minimized.

Copy link
@geek

geek Apr 29, 2015

Member

I need to add our lint rules... but we have an extra newline after every function declaration.

Please add a newline here and on line 17

This comment has been minimized.

Copy link
@geuis

geuis Apr 30, 2015

Author

updated

@geek

This comment has been minimized.

Copy link
Member

geek commented Apr 30, 2015

I need to make it into an error, but here are the linting results from the build:

Linting results:
    lib/providers/reddit.js:
        Line 25: hapi/hapi-scope-start - Missing blank line at beginning of function.
    test/providers.js:
        Line 74: hapi/hapi-scope-start - Missing blank line at beginning of function.
        Line 85: hapi/hapi-scope-start - Missing blank line at beginning of function.
@geuis

This comment has been minimized.

Copy link
Author

geuis commented Apr 30, 2015

When I run eslint locally, no errors reported:

eslint -c .eslintrc lib/providers/reddit.js 
eslint -c .eslintrc test/providers.js 

I corrected the errors. You might want to look at why eslint wasn't catching anything locally but did in travis. Maybe make eslint a required part of the npm package and update documentation to reflect its requirement.

Charles Lawrence
@geek

This comment has been minimized.

Copy link
Member

geek commented May 1, 2015

@geuis thanks for all of the work on this, merging and publishing now :)

geek added a commit that referenced this pull request May 1, 2015
Support Reddit as an OAuth provider
@geek geek merged commit 1756e7b into hapijs:master May 1, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.