Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location setting similar to old hapi server location #85

Merged
merged 4 commits into from May 4, 2015

Conversation

@brand7n
Copy link
Contributor

brand7n commented May 4, 2015

The forceHttps option is not sufficient to cover every configuration. For example the port visible to the user's browser may be different than the port inferred by the Hapi server. In fact, the host may also be different if there is a load balancer involved. This PR attempts to restore the flexibility available when bell referenced the Hapi server location setting.

brand7n added 3 commits May 4, 2015
@jplock

This comment has been minimized.

Copy link

jplock commented May 4, 2015

+1

2 similar comments
@suicidejack

This comment has been minimized.

Copy link

suicidejack commented May 4, 2015

+1

@eruizdechavez

This comment has been minimized.

Copy link

eruizdechavez commented May 4, 2015

+1

@geek geek added the feature label May 4, 2015
@geek geek added this to the 2.6.1 milestone May 4, 2015
@geek geek self-assigned this May 4, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented May 4, 2015

@brand7n well done, this looks great :)

geek added a commit that referenced this pull request May 4, 2015
add location setting similar to old hapi server location
@geek geek merged commit f8875ca into hapijs:master May 4, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brand7n

This comment has been minimized.

Copy link
Contributor Author

brand7n commented May 4, 2015

@geek awesome...thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.