Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadd location setting similar to old hapi server location #85
Conversation
This comment has been minimized.
This comment has been minimized.
jplock
commented
May 4, 2015
|
+1 |
2 similar comments
This comment has been minimized.
This comment has been minimized.
suicidejack
commented
May 4, 2015
|
+1 |
This comment has been minimized.
This comment has been minimized.
eruizdechavez
commented
May 4, 2015
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
@brand7n well done, this looks great :) |
geek
added a commit
that referenced
this pull request
May 4, 2015
add location setting similar to old hapi server location
This comment has been minimized.
This comment has been minimized.
|
@geek awesome...thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
brand7n commentedMay 4, 2015
The
forceHttpsoption is not sufficient to cover every configuration. For example the port visible to the user's browser may be different than the port inferred by the Hapi server. In fact, the host may also be different if there is a load balancer involved. This PR attempts to restore the flexibility available when bell referenced the Hapi server location setting.