Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass `forceHttps` and `location` to v1 client #87

Merged
merged 2 commits into from May 12, 2015
Merged

Conversation

@salzhrani
Copy link
Contributor

salzhrani commented May 10, 2015

Pass forceHttps and location to v1 client

@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented May 10, 2015

coverage failing on oauth.js line 510 ... not sure how to fix

@geek geek added the bug label May 11, 2015
@geek geek added this to the 2.7.1 milestone May 11, 2015
@geek geek self-assigned this May 11, 2015
@geek

This comment has been minimized.

Copy link
Member

geek commented May 11, 2015

You should be fine to delete line 510 since you are always passing in the protocol from info.protocol

If you look at the html report for coverage it should show what is needed.

Samy Al Zahrani
Remove line
@salzhrani

This comment has been minimized.

Copy link
Contributor Author

salzhrani commented May 12, 2015

Thanks for the feedback,It is green now. Hope to see this land soon.

geek added a commit that referenced this pull request May 12, 2015
Pass `forceHttps` and `location` to v1 client
@geek geek merged commit 47255a5 into hapijs:master May 12, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geek

This comment has been minimized.

Copy link
Member

geek commented May 12, 2015

@salzhrani this is now published with v2.7.1. Thanks

@salzhrani salzhrani deleted the salzhrani:v1-love branch May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.