Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth client resource() endpoint #91

Merged
merged 3 commits into from May 27, 2015
Merged

OAuth client resource() endpoint #91

merged 3 commits into from May 27, 2015

Conversation

@hueniverse
Copy link
Member

hueniverse commented May 26, 2015

Closes #90

This is a bit convoluted but required to keep it backwards compatible with minimal code repeats. In future breaking versions it will be worth getting rid of the request() and get() methods and just keep the new resource() one.

hueniverse added 2 commits May 26, 2015
@hueniverse hueniverse added the feature label May 26, 2015
@hueniverse hueniverse added this to the 2.9.0 milestone May 26, 2015

var provider = this.provider;
internals.Client.prototype._prepare = function (method, uri, params, oauth, options, next) {

This comment has been minimized.

Copy link
@geek

geek May 27, 2015

Member

is it clearer as callback instead of next ?

This comment has been minimized.

Copy link
@hueniverse

hueniverse May 27, 2015

Author Member

callback must be called on next tick, next does not.

@geek

This comment has been minimized.

Copy link
Member

geek commented May 27, 2015

Looks good, just one minor question on style.

geek added a commit that referenced this pull request May 27, 2015
OAuth client resource() endpoint
@geek geek merged commit 4b5650e into master May 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@geek geek deleted the client branch May 27, 2015
@hueniverse hueniverse restored the client branch May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.