Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null for domain #96

Merged
merged 1 commit into from Jun 9, 2015
Merged

Allow null for domain #96

merged 1 commit into from Jun 9, 2015

Conversation

@briandela
Copy link
Contributor

briandela commented Jun 2, 2015

The default value for domain is null. However the Joi validation does not accept null as valid. Plugins like crumb/yar allow null to be passed in for this. PR is to make it consistent to enable easily using the same variable for domain across multiple plugins.

@geek

This comment has been minimized.

Copy link
Member

geek commented Jun 3, 2015

This looks like a good change. It may seem like overkill for this case, but can you add a test that passes in null to verify this change and prevent future regressions of this setting.

@geek geek self-assigned this Jun 3, 2015
The default value for `domain` is `null`. However the Joi validation does not accept `null` as valid. Plugins like crumb/yar allow null to be passed in for this. PR is to make it consistent to enable easily using the same variable for `domain` across multiple plugins.
@briandela

This comment has been minimized.

Copy link
Contributor Author

briandela commented Jun 3, 2015

@geek - I've updated with the test.

@geek geek added the bug label Jun 9, 2015
@geek geek added this to the 3.0.1 milestone Jun 9, 2015
geek added a commit that referenced this pull request Jun 9, 2015
Allow null for domain
@geek geek merged commit 5b28e68 into hapijs:master Jun 9, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.