Skip to content

/boom

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove line from wrap function #148

Closed
niftylettuce opened this issue Mar 26, 2017 · 4 comments
Assignees
@arb
Labels
bug
Milestone
4.3.1

Comments

@niftylettuce
Copy link
Contributor

@niftylettuce niftylettuce commented Mar 26, 2017

https://github.com/hapijs/boom/blob/master/lib/index.js#L76

This causes #139 to break...
@dunnock

This comment has been minimized.

Sign in to view
Copy link
Contributor

@dunnock dunnock commented Mar 28, 2017 •
edited

Similar issue when pass Boom error, the condition is wrong, e.g. it should always pass when error.isBoom: 3aa4a8c#commitcomment-21496008
@zaggino

This comment has been minimized.

Sign in to view
Copy link

@zaggino zaggino commented Mar 28, 2017

Related issue - #142
@AdriVanHoudt

This comment has been minimized.

Sign in to view
Copy link
Contributor

@AdriVanHoudt AdriVanHoudt commented Mar 28, 2017

PR's are always welcome ;)
@dunnock

This comment has been minimized.

Sign in to view
Copy link
Contributor

@dunnock dunnock commented Mar 28, 2017

I will take it
dunnock added a commit to comaeio/boom that referenced this issue Mar 28, 2017
@dunnock
fix hapijs#148 when Boom supplied to wrapper
34c8361
@dunnock dunnock mentioned this issue Mar 28, 2017
Merged
@arb arb modified the milestone: 4.3.1 Mar 28, 2017
@arb arb added the bug label Mar 28, 2017
@arb arb self-assigned this Mar 28, 2017
@arb arb closed this in 544cc13 Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arb arb

Labels
bug
Projects
None yet
Milestone
  4.3.1
5 participants
@niftylettuce @dunnock @zaggino @AdriVanHoudt @arb
You can’t perform that action at this time.