Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .npmignore #108

Closed
wants to merge 1 commit into from

Conversation

@jamiebuilds
Copy link

jamiebuilds commented May 1, 2016

No description provided.

@gergoerdosi

This comment has been minimized.

Copy link
Contributor

gergoerdosi commented May 1, 2016

See this issue: hapijs/hapi#1985

@jamiebuilds

This comment has been minimized.

Copy link
Author

jamiebuilds commented May 1, 2016

Whaat? @hueniverse I think the general consensus on this has definitely changed. node_modules could be a tenth of the size if people didn't send down megabytes of test directories (and other files) that aren't used.

At the very least don't include images..

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 2, 2016

@thejameskyle feel free to bring it up again in hapijs/contrib.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented May 2, 2016

I don't understand why this is such an issue? How often are you installing modules that the slight overhead causes a problem?

@jamiebuilds

This comment has been minimized.

Copy link
Author

jamiebuilds commented May 2, 2016

How often are you installing modules that the slight overhead causes a problem?

We install everything fresh every time we deploy or run CI. This isn't a slight overhead, if you take all of the test/ directories in all of the node_modules its hundreds of megabytes.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented May 2, 2016

I agree with @hueniverse, let's reopen the discussion in hapijs/contrib since this is a cross cutting issue.

@@ -0,0 +1,6 @@
images

This comment has been minimized.

Copy link
@arb

arb Jun 18, 2016

Contributor

So after it's been debating a few different places, I think the "standard" is:

*
!lib/**

Check https://github.com/hapijs/good/blob/master/.npmignore as a reference.

@arb arb modified the milestone: 3.2.2 Jun 20, 2016
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jun 20, 2016

@thejameskyle are you still interested in landing this? Otherwise I'm going to close and open a new PR.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jun 21, 2016

Trumped by #121

@arb arb closed this Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.