Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename serverTimeout to serverUnavailable #119

Merged
merged 3 commits into from Jun 20, 2016

Conversation

@savardc
Copy link
Contributor

savardc commented Jun 16, 2016

Modifications for #117

README.md Outdated
@@ -40,7 +40,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb)
- [`Boom.badImplementation([message], [data])`](#boombadimplementationmessage-data)
- [`Boom.notImplemented([message], [data])`](#boomnotimplementedmessage-data)
- [`Boom.badGateway([message], [data])`](#boombadgatewaymessage-data)
- [`Boom.serverTimeout([message], [data])`](#boomservertimeoutmessage-data)
- [`Boom.serverUnavailable([message], [data])`](#boomserverunavailablemessage-data)

This comment has been minimized.

Copy link
@arb

arb Jun 16, 2016

Contributor

Undo the changes to the table of contents; it is automatically generated.

@arb arb self-assigned this Jun 16, 2016
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jun 16, 2016

You'll need to keep serverTimeout. I don't want to do a breaking change. Just add serverUnavailable as an alias to serverTimeout and update the documentation to talk about serverUnavailable

@savardc

This comment has been minimized.

Copy link
Contributor Author

savardc commented Jun 16, 2016

I kept it, line 384

On Thu, Jun 16, 2016 at 4:22 PM Adam Bretz notifications@github.com wrote:

You'll need to keep serverTimeout. I don't to do a breaking change. Just
add serverUnavailable as an alias to serverTimeout and update the
documentation to talk about serverUnavailable


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#119 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AA096oeXDpGeUjv8DysJqM9lVojnZFHeks5qMbCFgaJpZM4I3pGR
.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Jun 17, 2016

Can you also keep the test in so we can be absolutely sure it doesn't break. We'll remove it all in a subsequent release.

@arb arb changed the title Rename serverTiemout to serverUnavailable Rename serverTimeout to serverUnavailable Jun 17, 2016
@arb arb added this to the 3.2.2 milestone Jun 20, 2016
@arb arb merged commit c082525 into hapijs:master Jun 20, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.