Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorized extension for #146 #147

Merged
merged 3 commits into from Mar 21, 2017

Conversation

@simon-p-r
Copy link
Contributor

simon-p-r commented Mar 20, 2017

Here is small PR for issue #146.

simon-p-r added 2 commits Mar 20, 2017
@@ -170,7 +170,7 @@ exports.unauthorized = function (message, scheme, attributes) { // Or f
err.output.payload.attributes = {};
}

if (attributes) {

This comment has been minimized.

Copy link
@hueniverse

hueniverse Mar 20, 2017

Member

I would still structure it by checking for attributes first, then handling the diff types.

@hueniverse hueniverse self-assigned this Mar 21, 2017
@hueniverse hueniverse added this to the 4.3.0 milestone Mar 21, 2017
@hueniverse hueniverse added the feature label Mar 21, 2017
@hueniverse hueniverse merged commit 648acb1 into hapijs:master Mar 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.