Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override data if user error already have a data attribute #17

Merged
merged 2 commits into from Mar 1, 2014

Conversation

@vbardales
Copy link
Contributor

vbardales commented Feb 27, 2014

I have a customized error class that is an instance of Error, but I already have a data attribute which is overriden by boom with no reason ...

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Feb 27, 2014

Test please.

@hueniverse hueniverse added this to the 2.3.0 milestone Feb 27, 2014
@hueniverse hueniverse self-assigned this Feb 27, 2014
@hueniverse hueniverse added bug and removed enhancement labels Feb 27, 2014
@vbardales

This comment has been minimized.

Copy link
Contributor Author

vbardales commented Feb 28, 2014

test added

hueniverse added a commit that referenced this pull request Mar 1, 2014
Don't override data if user error already have a data attribute
@hueniverse hueniverse merged commit e33b039 into hapijs:master Mar 1, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.