Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

424 Failed dependency implementation #188

Merged
merged 4 commits into from Feb 28, 2018

Conversation

@danielmachado
Copy link
Contributor

danielmachado commented Feb 27, 2018

Hi guys, i'm missing this feature so please don't you mind to include it?

Specs, implementation and documentation are included.

Copy link
Contributor

AdriVanHoudt left a comment

LGTM

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Feb 27, 2018

Looks good. I'll let @arb merge and publish.

@hueniverse hueniverse added the feature label Feb 27, 2018
README.md Outdated
@@ -36,6 +36,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb)
- [`Boom.teapot([message], [data])`](#boomteapotmessage-data)
- [`Boom.badData([message], [data])`](#boombaddatamessage-data)
- [`Boom.locked([message], [data])`](#boomlockedmessage-data)
- [`Boom.failedDependency([message], [data])`](#boomfaileddependencymessage-data)

This comment has been minimized.

Copy link
@arb

arb Feb 27, 2018

Contributor

Remove please. The TOC will be automatically generated.

@arb arb added this to the 7.2.0 milestone Feb 27, 2018
@arb arb self-assigned this Feb 27, 2018
@danielmachado

This comment has been minimized.

Copy link
Contributor Author

danielmachado commented Feb 28, 2018

@arb CR addressed.

@arb
arb approved these changes Feb 28, 2018
@arb arb merged commit c897ab6 into hapijs:master Feb 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.