Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boom.teapot() method with documentation and tests #78

Merged
merged 2 commits into from Mar 21, 2017

Conversation

@mtharrison
Copy link
Member

mtharrison commented Oct 29, 2015

馃嵉

@mtharrison mtharrison changed the title :tea: Add Boom.teapot() method with documentation and tests :tea: Add Boom.teapot() method with documentation and tests Oct 29, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Oct 29, 2015

馃嵉:shipit:

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Oct 29, 2015

Really?

@hueniverse hueniverse added the feature label Oct 29, 2015
@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Oct 29, 2015

Well, it is an irreverent joke taken maybe a bit too far. But would it really be so bad to have it? Error handling just isn't much fun and this could definitely add a smile to someone's face at just the right time.

That being said, I would understand if you want to close it.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Oct 30, 2015

I don't really care, just seems like a waste of your time.

@devinivy

This comment has been minimized.

Copy link
Member

devinivy commented Oct 31, 2015

This enhancement looks good to me.

@danivek

This comment has been minimized.

Copy link

danivek commented Nov 5, 2015

+1 You made my day !

@devinivy

This comment has been minimized.

Copy link
Member

devinivy commented Nov 5, 2015

@mtharrison looks like this needs a rebase.

@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Nov 6, 2015

I have a feeling this won't get merged.

@mtharrison mtharrison closed this Nov 6, 2015
@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Nov 6, 2015

have faith! 馃嵉

@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Nov 6, 2015

I was waiting oolong 馃槈

@AdriVanHoudt AdriVanHoudt mentioned this pull request Dec 21, 2015
@jxom

This comment has been minimized.

Copy link

jxom commented Mar 1, 2017

Can we please get this merged?? It is a legitimate HTTP status!!!!1111 馃嵉馃嵉馃嵉馃嵉馃嵉馃嵉

@jxom

This comment has been minimized.

Copy link

jxom commented Mar 1, 2017

@hapijs pls respond

@daveols

This comment has been minimized.

Copy link

daveols commented Mar 1, 2017

I'd love to see this, if not only to support RFC 2324 completely.

@lloydbenson

This comment has been minimized.

Copy link
Contributor

lloydbenson commented Mar 1, 2017

This issue is closed? Maybe open a new issue and reference this?

@AdriVanHoudt

This comment has been minimized.

Copy link
Contributor

AdriVanHoudt commented Mar 2, 2017

@arb since you are the maintainer we really need your view on this! It is tea important to let this pass imo!

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Mar 2, 2017

@lloydbenson side channeled me and I said "if someone opens a new PR, I'll take it."

@mtharrison mtharrison reopened this Mar 3, 2017
@mtharrison

This comment has been minimized.

Copy link
Member Author

mtharrison commented Mar 3, 2017

I've rebased this, so it should be ready to go.

- `data` - optional additional error data.

```js
Boom.teapot('sorry, no coffee...');

This comment has been minimized.

Copy link
@devinivy

devinivy Mar 3, 2017

Member

Should have an upper-cased "S" on "sorry" to match the response payload below.

This comment has been minimized.

Copy link
@richardlay

richardlay Mar 6, 2017

Awesome. It is very short...and stout

@@ -32,6 +32,7 @@ Lead Maintainer: [Adam Bretz](https://github.com/arb)
- [`Boom.unsupportedMediaType([message], [data])`](#boomunsupportedmediatypemessage-data)
- [`Boom.rangeNotSatisfiable([message], [data])`](#boomrangenotsatisfiablemessage-data)
- [`Boom.expectationFailed([message], [data])`](#boomexpectationfailedmessage-data)
- [`Boom.teapot([message], [data])`](#boomteapotmessage-data)

This comment has been minimized.

Copy link
@arb

arb Mar 3, 2017

Contributor

Please remove. There is a tool to generate the TOC on new versions.

@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Mar 20, 2017

Still absurd waste of time.

@hugomd

This comment has been minimized.

Copy link

hugomd commented Mar 20, 2017

@hueniverse We've already wasted our time though, and it cannot be taken back!

@jxom

This comment has been minimized.

Copy link

jxom commented Mar 21, 2017

@hueniverse Full support of RFC 2324 is not a waste of time! 馃槺

@hueniverse hueniverse self-assigned this Mar 21, 2017
@hueniverse hueniverse added this to the 4.3.0 milestone Mar 21, 2017
@hueniverse hueniverse merged commit 116ba7d into hapijs:master Mar 21, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jxom

This comment has been minimized.

Copy link

jxom commented Mar 21, 2017

@jxom jxom mentioned this pull request Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can鈥檛 perform that action at this time.