Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctor passing in serverError helper #80

Merged
merged 2 commits into from Oct 30, 2015

Conversation

@kpdecker
Copy link
Contributor

kpdecker commented Oct 29, 2015

Fixes #79

Fixes #79
@arb

This comment has been minimized.

Copy link
Contributor

arb commented Oct 29, 2015

Can we add some kind of test to prevent a regression in the future?

@kpdecker

This comment has been minimized.

Copy link
Contributor Author

kpdecker commented Oct 30, 2015

Tests added for all error generators.

@hueniverse hueniverse added the bug label Oct 30, 2015
@arb arb added this to the 2.10.1 milestone Oct 30, 2015
@arb arb self-assigned this Oct 30, 2015
arb added a commit that referenced this pull request Oct 30, 2015
Fix ctor passing in serverError helper
@arb arb merged commit aa3efe3 into master Oct 30, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@arb arb deleted the server-error-trace branch Oct 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.