Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #24

Merged
merged 1 commit into from Nov 20, 2014
Merged

Cleanup #24

merged 1 commit into from Nov 20, 2014

Conversation

@arb
Copy link
Contributor

arb commented Nov 19, 2014

  • Cleaned for slice issue as the previous solution went against style guide here
  • Updated test to prove it works
  • I would consider this a breaking change because if your logic has already added the two junk values into the array, that is going to be broken going forward with this change.
sericaia added a commit that referenced this pull request Nov 20, 2014
Cleanup
@sericaia sericaia merged commit c21acf9 into hapijs:master Nov 20, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 20, 2014

@danielaborges this should be assigned a milestone appropriate to the change.

@sericaia sericaia added this to the 1.0.3 milestone Nov 20, 2014
@arb

This comment has been minimized.

Copy link
Contributor Author

arb commented Nov 20, 2014

This is a breaking/api level change, so I think it should be attached to milestone 2.0.0.

@sericaia sericaia modified the milestones: 2.0.0, 1.0.3 Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.