Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to current hapi.js standards #47

Merged
merged 3 commits into from Apr 27, 2016
Merged

Conversation

@sericaia
Copy link
Contributor

sericaia commented Apr 25, 2016

Solves #46

.travis.yml Outdated
- iojs
- 4.0
- 4
- 5

This comment has been minimized.

Copy link
@hueniverse

hueniverse Apr 25, 2016

Member

Just 4 and latest

var name = names[i];
var def = Hoek.clone(definition[name]);
const names = Object.keys(definition);
for (let i = 0, il = names.length; i < il; ++i) {

This comment has been minimized.

Copy link
@hueniverse

hueniverse Apr 25, 2016

Member

we no longer use the il convention.

def.name = name;
keys[name] = def;
if (def.alias) {
for (var a = 0, al = def.alias.length; a < al; ++a) {
for (let a = 0, al = def.alias.length; a < al; ++a) {

This comment has been minimized.

Copy link
@hueniverse

hueniverse Apr 25, 2016

Member

If you update to the latest lab and code, this will error.

@sericaia sericaia force-pushed the sericaia:master branch from 6a21379 to 2ab80c5 Apr 26, 2016
@sericaia

This comment has been minimized.

Copy link
Contributor Author

sericaia commented Apr 27, 2016

@hueniverse is it fine now?

@hueniverse hueniverse merged commit 2e22549 into hapijs:master Apr 27, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hueniverse hueniverse added this to the 2.0.1 milestone Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.