Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using catbox-memcache with yar, response body is replaced with `true` #9

Closed
avaly opened this issue Oct 23, 2014 · 2 comments
Closed

Using catbox-memcache with yar, response body is replaced with `true` #9

avaly opened this issue Oct 23, 2014 · 2 comments
Assignees
Labels
bug
Milestone

Comments

@avaly
Copy link

@avaly avaly commented Oct 23, 2014

See details at: hapijs/yar#53

@chapel chapel self-assigned this Nov 20, 2014
@chapel chapel added the bug label Nov 20, 2014
@chapel

This comment has been minimized.

Copy link
Contributor

@chapel chapel commented Nov 20, 2014

Will take a look.

@chapel chapel added this to the 1.1.1 milestone Nov 20, 2014
@vadzappa

This comment has been minimized.

Copy link
Contributor

@vadzappa vadzappa commented Dec 29, 2014

In order to fix this catbox-memcached should use this:

this.client.set(cacheKey, stringifiedEnvelope, ttlSec, function(err){
    if (err){
        callback(err);
    } else {
        callback();
    }
});

instead of this:

this.client.set(cacheKey, stringifiedEnvelope, ttlSec, callback);
vadzappa added a commit to vadzappa/catbox-memcached that referenced this issue Dec 29, 2014
chapel added a commit that referenced this issue Jan 18, 2015
#9 fix
@chapel chapel closed this Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.