Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why peer depend instead of verify in parent #1

Closed
Raynos opened this issue Apr 16, 2014 · 1 comment
Closed

why peer depend instead of verify in parent #1

Raynos opened this issue Apr 16, 2014 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@Raynos
Copy link

@Raynos Raynos commented Apr 16, 2014

What is the motivation for having npm verify the compatibility between catbox-memory and catbox.

catbox itself could throw if a store interface that's not compatible with catbox 2.x was installed.

What benefit does peer dependencies bring for this use case ?

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Apr 16, 2014

Should have been removed (we removed it from the others). The benefit would be that we get this test for free instead of keeping track of the specific ways in which different versions of catbox work. This was the first time we broke the modules out and using peerDeps made it a nightmare. I didn't realize we forgot to remove this one.

@hueniverse hueniverse added the bug label Apr 16, 2014
@hueniverse hueniverse added this to the 1.0.2 milestone May 20, 2014
@hueniverse hueniverse self-assigned this May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.