Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffers can change while in cache #55

Closed
kanongil opened this issue Jan 24, 2018 · 1 comment
Closed

Buffers can change while in cache #55

kanongil opened this issue Jan 24, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@kanongil
Copy link
Member

@kanongil kanongil commented Jan 24, 2018

With allowMixedContent = true, the stored buffers can be modified by writing to the returned Buffer item from a get() call.

I suspect another copy() is required on get() to handle this since there are no read-only buffers.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Jan 25, 2018

I'm ok with adding a config to change this, but otherwise this is an overkill.

@hueniverse hueniverse self-assigned this Oct 30, 2018
@hueniverse hueniverse added the feature label Oct 30, 2018
@hueniverse hueniverse added this to the 4.0.0 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.