Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Buffers #15

Merged
merged 5 commits into from Sep 9, 2014
Merged

Add support for Buffers #15

merged 5 commits into from Sep 9, 2014

Conversation

@cjihrig
Copy link
Contributor

cjihrig commented Sep 9, 2014

Closes #5

avitale and others added 4 commits Jun 17, 2014
@cjihrig cjihrig added the feature label Sep 9, 2014
@cjihrig cjihrig added this to the 2.0.0 milestone Sep 9, 2014
@cjihrig cjihrig mentioned this pull request Sep 9, 2014
@geek geek self-assigned this Sep 9, 2014
// copy buffer to prevent value from changing while in the cache
value.copy(this.item);
valueByteSize = this.item.length;
} else {

This comment has been minimized.

Copy link
@geek

geek Sep 9, 2014

Member

else on its own line

@@ -103,7 +114,12 @@ internals.Connection.prototype.get = function (key, callback) {

var value = null;
try {

This comment has been minimized.

Copy link
@geek

geek Sep 9, 2014

Member

It may be worth moving the try into a separate function so that the get function can be optimized

geek added a commit that referenced this pull request Sep 9, 2014
Add support for Buffers
@geek geek merged commit 41d87ba into hapijs:master Sep 9, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@cjihrig cjihrig deleted the cjihrig:buffers branch Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.