Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Buffers #15
Merged
Conversation
lib/index.js
Outdated
| // copy buffer to prevent value from changing while in the cache | ||
| value.copy(this.item); | ||
| valueByteSize = this.item.length; | ||
| } else { |
This comment has been minimized.
This comment has been minimized.
lib/index.js
Outdated
| @@ -103,7 +114,12 @@ internals.Connection.prototype.get = function (key, callback) { | |||
|
|
|||
| var value = null; | |||
| try { | |||
This comment has been minimized.
This comment has been minimized.
geek
Sep 9, 2014
Member
It may be worth moving the try into a separate function so that the get function can be optimized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cjihrig commentedSep 9, 2014
Closes #5