Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note to readme about the limitation of ttl #37

Merged
merged 2 commits into from Jun 2, 2016

Conversation

@paulovieira
Copy link
Contributor

paulovieira commented May 30, 2016

No description provided.

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented May 30, 2016

You misunderstood me, big-time needs to be added to the library, you don't have the possibility to override it externally.

@paulovieira

This comment has been minimized.

Copy link
Contributor Author

paulovieira commented May 30, 2016

Yeah, I got it. The user would have to patch the module directly (easy fix). The note should be more clear though. But let's wait to see if @cjihrig wants to add it directly or via some kind of option.

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented May 30, 2016

I'm open to using big-time. I actually tried this before in #29, but @hueniverse said no because it required babel (rest params). However, this is no longer the case in Node 6.

@hueniverse are you still 👎 on the idea?

@cjihrig

This comment has been minimized.

Copy link
Contributor

cjihrig commented May 31, 2016

FYI - big-time is now updated to drop Babel as of arb/big-time#15

README.md Outdated
@@ -7,6 +7,8 @@ Lead Maintainer - [Colin Ihrig](https://github.com/cjihrig)

Current version: [![Current Version](https://img.shields.io/npm/v/catbox-memory.svg)](https://www.npmjs.org/package/catbox-memory) [![Build Status](https://api.travis-ci.org/hapijs/catbox-memory.svg)](https://travis-ci.org/hapijs/catbox-memory)


This comment has been minimized.

Copy link
@cjihrig

cjihrig Jun 1, 2016

Contributor

Please remove these whitespace changes.

README.md Outdated
@@ -18,3 +20,5 @@ Current version: [![Current Version](https://img.shields.io/npm/v/catbox-memory.
`Buffer` data can be stored alongside the stringified data. `Buffer`s are not
stringified, and are copied before storage to prevent the value from changing while
in the cache. Defaults to `false`.

Note: the maximum allowed value for `ttl` is `2^31-1`, which is around 24.8 days. If you need more than that use [big-time](https://www.npmjs.com/package/big-time).

This comment has been minimized.

Copy link
@cjihrig

cjihrig Jun 1, 2016

Contributor

Please remove the second sentence.

@paulovieira

This comment has been minimized.

Copy link
Contributor Author

paulovieira commented Jun 2, 2016

The pr has been updated.

@cjihrig cjihrig merged commit 048f92f into hapijs:master Jun 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cjihrig cjihrig added this to the 2.0.3 milestone Jun 2, 2016
@cjihrig cjihrig self-assigned this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.