Upgrade outdated node-redis dependency #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LoicMahieu any chance we can get this looked at? There are currently issues with the library that cause exceptions to be thrown - not good! |
|
This is causing us some issues, it would be good if someone could take a look at this. |
|
👍 Would like this too |
|
Could we get someone look into this, it casing us some issue too. |
|
Sorry for the delay. Obviously thanks for you PR, looks good! |
LoicMahieu
added a commit
that referenced
this pull request
Oct 30, 2015
Upgrade outdated node-redis dependency
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node-redis library is a few versions out of date here. Some of the fixes that have gone in to that library include better error handling - in particular, it no longer throws exceptions. Obviously, throwing exceptions here can cause havok to an application, so these changes are particularly desirable.
There are some breaking changes in the updates, but everything seems ok apart from one amend needed in a unit test - it seems to have been a redundant
quitcall, but some clarification on whether this is ok would be good.