Skip to content

/catbox

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to better organize config options #12

Closed
hueniverse opened this issue Dec 28, 2012 · 6 comments
Closed

Need to better organize config options #12

hueniverse opened this issue Dec 28, 2012 · 6 comments
Assignees
@geek
Labels
documentation
Milestone
0.1.0

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Dec 28, 2012

List the common ones first, then the ones specific to each engine type (including host/port).
@ghost ghost assigned geek Dec 28, 2012
@geek geek mentioned this issue Dec 28, 2012
Merged
@geek geek closed this Dec 28, 2012
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member Author

@hueniverse hueniverse commented Dec 29, 2012

Not done...
@hueniverse hueniverse reopened this Dec 29, 2012
@geek

This comment has been minimized.

Sign in to view
Copy link
Member

@geek geek commented Dec 29, 2012

https://github.com/walmartlabs/catbox/blob/develop/README.md is now updated. Please review.
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member Author

@hueniverse hueniverse commented Dec 29, 2012

Should move the defaults into the sections above since we now have those listed.
@geek

This comment has been minimized.

Sign in to view
Copy link
Member

@geek geek commented Dec 31, 2012

Moved the defaults into the appropriate sections... please review.
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member Author

@hueniverse hueniverse commented Dec 31, 2012

To be consistent with hapi docs, should say 'Defaults to ...' or 'Defaults to no limit' / 'no authentication' / etc...
@geek

This comment has been minimized.

Sign in to view
Copy link
Member

@geek geek commented Dec 31, 2012

Defaults are now formatted similarly to hapi,
@hueniverse hueniverse closed this Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geek geek

Labels
documentation
Projects
None yet
Milestone
  0.1.0
2 participants
@hueniverse @geek
You can’t perform that action at this time.