Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If generate takes longer than staleTimeout, errors get swallowed #210

Closed
jgallen23 opened this issue Feb 1, 2019 · 1 comment
Closed

If generate takes longer than staleTimeout, errors get swallowed #210

jgallen23 opened this issue Feb 1, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@jgallen23
Copy link

@jgallen23 jgallen23 commented Feb 1, 2019

We have a method that gets data from a 3rd party api and we are ok with it returning stale data most of the time, so we set the staleTimeout to 1 and the staleIn to 3 hours and expiresIn to 10 days and dropOnError to false. Inside our method, we just make a call to the 3rd party api and let it throw if it fails. The problem is that because the staleTimeout is always less than the request time, any errors that happen inside the method get completely swallowed and we don't get any visibility until the expiresIn passes and then our service stops serving stale data and goes down.

Do others run into this issue? Is it worth submitting a PR? (My last one is still sitting there, so I'm not sure if you'd be open to it)

@hueniverse hueniverse self-assigned this Apr 1, 2019
@hueniverse hueniverse added the feature label Apr 1, 2019
@hueniverse hueniverse added this to the 10.1.1 milestone Apr 1, 2019
@hueniverse hueniverse closed this in f81e797 Apr 1, 2019
@jgallen23

This comment has been minimized.

Copy link
Author

@jgallen23 jgallen23 commented Apr 1, 2019

thanks @hueniverse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.