Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
StaleIn can be function. #105
If you run test on catbox Master it will fail occasionally. Likely because of tight timing.. I thought that I identified it in #106, but I just test this adjustment again and it still fails occasionally, so I probably just had lucky row..
Generally relying on 1ms difference in timing seems to be unreliable. I will try to identify which test(s) is causing this.
Is there actually trick how can I see which tests are going through particular line? That would help me to narrow the search.
Right, this is updated.
With regards to timing reliability. Tests on Master are reliable once I switch off everything (including spotify :) ), with higher cpu load timing gets crazy, which is fair enough. I understand that its about having balance between reliability and tests duration.
This pull request tend to fails occasionally (about 30% failure rate) with
Which is when this if is not true:
So I spend half day trying to understand the cause. I thought that
Anyway #106 updates timing for this particular failure, so it works properly. I am basically just trying justify here, that this occasional failure seems to be caused by adding tests, not by tests or code itself. I hope I am not wrong..