Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pendingGenerateTimeout timeout issue #185

Merged
merged 6 commits into from Jul 14, 2017

Conversation

@kanongil
Copy link
Member

kanongil commented Jun 16, 2017

This provides a proper fix for the pendingGenerateTimeout invalid response issue in #177 & #184. This is done by hijacking abandoned pending generates, where the originating request has already responded (using a timeout).

@kanongil kanongil force-pushed the kanongil:pendings-refactor branch from 73c0e77 to 9014310 Jul 14, 2017
@kanongil kanongil merged commit 32cbaef into hapijs:master Jul 14, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kanongil kanongil self-assigned this Jul 14, 2017
@kanongil kanongil added the bug label Jul 14, 2017
@kanongil kanongil added this to the 7.1.5 milestone Jul 14, 2017
@kanongil kanongil changed the title Pendings refactor Fix pendingGenerateTimeout timeout issue Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.