Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ioredis client option for catbox-redis #206

Merged
merged 2 commits into from Dec 18, 2018

Conversation

@willrstern
Copy link
Contributor

willrstern commented Nov 16, 2018

catbox-redis should support passing a custom ioredis client via the client option, but Hoek's merge breaks the ioredis instance - I believe because context is lost.

Using Object.assign works.

Supporting client is required as you have to create a more custom ioredis instance for cluster support.

@willrstern willrstern mentioned this pull request Nov 19, 2018
@willrstern

This comment has been minimized.

Copy link
Contributor Author

willrstern commented Dec 6, 2018

Just a ping on this...any issues with this getting merged in?

lib/client.js Outdated Show resolved Hide resolved
Copy link
Member

kanongil left a comment

This should help fix hapijs/hapi#3876.

@willrstern

This comment has been minimized.

Copy link
Contributor Author

willrstern commented Dec 10, 2018

This will also create a solution for hapijs/catbox-redis#94 by allowing for passing in an ioredis cluster instance directly to Catbox. Connecting to a Redis cluster is how I found this bug.

@daveashworth

This comment has been minimized.

Copy link

daveashworth commented Dec 14, 2018

Any updates on merging this @kanongil? Would love to take advantage of this change! 😄

@kanongil kanongil merged commit a871293 into hapijs:master Dec 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kanongil added a commit that referenced this pull request Dec 18, 2018
@kanongil kanongil added this to the 10.0.6 milestone Dec 18, 2018
@kanongil kanongil added the bug label Dec 18, 2018
@kanongil kanongil self-assigned this Dec 18, 2018
@kanongil

This comment has been minimized.

Copy link
Member

kanongil commented Dec 18, 2018

10.0.6 has been published – sorry about the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.