Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport ioredis client option for catbox-redis #206
Merged
Conversation
Closed
This comment has been minimized.
This comment has been minimized.
|
Just a ping on this...any issues with this getting merged in? |
|
This should help fix hapijs/hapi#3876. |
This comment has been minimized.
This comment has been minimized.
|
This will also create a solution for hapijs/catbox-redis#94 by allowing for passing in an ioredis cluster instance directly to Catbox. Connecting to a Redis cluster is how I found this bug. |
This comment has been minimized.
This comment has been minimized.
daveashworth
commented
Dec 14, 2018
|
Any updates on merging this @kanongil? Would love to take advantage of this change! |
This comment has been minimized.
This comment has been minimized.
|
10.0.6 has been published – sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
willrstern commentedNov 16, 2018
•
edited
catbox-redisshould support passing a custom ioredis client via theclientoption, butHoek'smergebreaks the ioredis instance - I believe because context is lost.Using Object.assign works.
Supporting
clientis required as you have to create a more custom ioredis instance for cluster support.