Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upProblems with concurrent invocation of getOrGenerate. #85
Conversation
This comment has been minimized.
This comment has been minimized.
|
We found this problem by introspecting on non-deterministic caching failures during concurrent requests (we were using hapi@6.4.0 and catbox@3.4.1). |
This comment has been minimized.
This comment has been minimized.
|
Rad - taking a look now. |
This comment has been minimized.
This comment has been minimized.
|
I have a simpler solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cgc commentedSep 16, 2014
A sample issue can be found in bfb5508. A possible fix is in f753003. If you like my fix, ebfb07f gets me to 100% coverage.