Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with concurrent invocation of getOrGenerate. #85

Closed
wants to merge 3 commits into from

Conversation

@cgc
Copy link

cgc commented Sep 16, 2014

A sample issue can be found in bfb5508. A possible fix is in f753003. If you like my fix, ebfb07f gets me to 100% coverage.

@cgc

This comment has been minimized.

Copy link
Author

cgc commented Sep 16, 2014

We found this problem by introspecting on non-deterministic caching failures during concurrent requests (we were using hapi@6.4.0 and catbox@3.4.1).

cgc added 2 commits Sep 16, 2014
This helps with concurrent requests and mimics the scheme used for
per-ID pending callbacks.
@nvcexploder

This comment has been minimized.

Copy link
Contributor

nvcexploder commented Sep 16, 2014

Rad - taking a look now.

@hueniverse hueniverse added the bug label Sep 16, 2014
@hueniverse hueniverse added this to the 3.4.2 milestone Sep 16, 2014
@hueniverse hueniverse self-assigned this Sep 16, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Sep 16, 2014

I have a simpler solution.

hueniverse added a commit that referenced this pull request Sep 16, 2014
@hueniverse hueniverse closed this Sep 16, 2014
nvcexploder added a commit that referenced this pull request Sep 16, 2014
Fix concurrent getOrGenerate bug. Closes #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.