Skip to content

/code

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove engines #130

Closed
hueniverse opened this issue Nov 2, 2018 · 3 comments
Assignees
@hueniverse
Labels
non issue
Milestone
5.2.3

Comments

@hueniverse
Copy link
Member

@hueniverse hueniverse commented Nov 2, 2018

No description provided.

@hueniverse hueniverse added the non issue label Nov 2, 2018
@hueniverse hueniverse added this to the 5.2.3 milestone Nov 2, 2018
@hueniverse hueniverse self-assigned this Nov 2, 2018
@hueniverse hueniverse closed this in ef8eccf Nov 2, 2018
@zipzapp

This comment has been minimized.

Sign in to view
Copy link

@zipzapp zipzapp commented Dec 4, 2018

Why remove 'engines' if the package isn't compatible with older versions of node? Tried pulling in this library on a node 6.11.0 project but it uses async/await, which isn't supported in that version. This would have at least provided that warning.
@cjihrig

This comment has been minimized.

Sign in to view
Copy link
Contributor

@cjihrig cjihrig commented Dec 4, 2018

It was removed because the engines field doesn't help much. It only prints an easy to miss warning during npm install.
@hueniverse

This comment has been minimized.

Sign in to view
Copy link
Member Author

@hueniverse hueniverse commented Dec 4, 2018

Removed mostly due to inconsistent handling between npm and yarn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hueniverse hueniverse

Labels
non issue
Projects
None yet
Milestone
  5.2.3
3 participants
@hueniverse @zipzapp @cjihrig
You can’t perform that action at this time.