Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

once flag should change error message #47

Closed
mtharrison opened this issue Nov 25, 2015 · 1 comment
Assignees
Labels
bug
Milestone

Comments

@mtharrison
Copy link
Member

@mtharrison mtharrison commented Nov 25, 2015

The once flag doesn't change the error message:

expect([1,2,2]).to.once.include(2); => Error: Expected [ 1, 2, 2 ] to include 2

Which looks kinda weird because it does include 2. I think once should change the error message as not does:

expect([1,2,2]).to.not.include(2); => Error: Expected [ 1, 2, 2 ] to not include 2

@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Nov 25, 2015

I'll take a PR for this if anyone feels like working on this before I get to it.

@cjihrig cjihrig added the bug label Nov 27, 2015
@cjihrig cjihrig added this to the 2.0.2 milestone Nov 27, 2015
@cjihrig cjihrig self-assigned this Nov 27, 2015
@geek geek closed this in #48 Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.