Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with internals.at #57

Closed
simon-p-r opened this issue Mar 10, 2016 · 3 comments
Assignees
Labels
bug
Milestone

Comments

@simon-p-r
Copy link

@simon-p-r simon-p-r commented Mar 10, 2016

Hi

I am having a problem with this line https://github.com/hapijs/code/blob/master/lib/index.js#L435, due to the value of "const at". Sometimes the value is null meaning the return value from function throws an error and then shows "thrown errors in test" message in tests being run by lab.

@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Mar 10, 2016

Can you provide an example?

@simon-p-r

This comment has been minimized.

Copy link
Author

@simon-p-r simon-p-r commented Mar 10, 2016

Not easily, it was due to a thrown ENONENT error. I resolved by destroying and recreating path for every test run by lab.

@simon-p-r simon-p-r closed this Mar 10, 2016
@simon-p-r simon-p-r reopened this Mar 10, 2016
@cjihrig

This comment has been minimized.

Copy link
Contributor

@cjihrig cjihrig commented Mar 10, 2016

Reproduction:

const Fs = require('fs');
const Code = require('code');

Fs.readFile('./thisfiledoesntexist', (err) => {
  Code.expect(err).to.not.exist();
});

I'll try to get to this over the weekend.

@cjihrig cjihrig added the bug label Mar 11, 2016
@cjihrig cjihrig added this to the 2.1.1 milestone Mar 11, 2016
@cjihrig cjihrig self-assigned this Mar 11, 2016
@cjihrig cjihrig closed this in #58 Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.