Use server.decorate() instead of assignment

[leesei]

See Eran's comment:
#103 (comment)

[jaw187]

Thanks @leesei I've seen it and have the work done locally.

[leesei]

Thanks.
Close this upon commit?

[jaw187]

👍 Struggling with how to access reply from within a function passed to server.decorate. Any suggestion?

[mtharrison]

@jaw187 what are you trying to do, why do you need reply()? Can you show some code?

[jaw187]

@mtharrison All of the code I'm assigning to request.cookieAuth needs to be done using server.decorate, but since server.decorate has to be called before the extension point I'll only have access to request by setting the apply option to server.decorate

    server.ext('onPreAuth', (request, reply) => {

        request.cookieAuth = {
            set: function (session, value) {

                if (arguments.length > 1) {
                    const key = session;
                    Hoek.assert(key && typeof key === 'string', 'Invalid session key');
                    session = request.auth.artifacts;
                    Hoek.assert(session, 'No active session to apply key to');

                    session[key] = value;
                    return reply.state(settings.cookie, session);
                }

                Hoek.assert(session && typeof session === 'object', 'Invalid session');
                request.auth.artifacts = session;
                reply.state(settings.cookie, session);
            },
            clear: function (key) {

                if (arguments.length) {
                    Hoek.assert(key && typeof key === 'string', 'Invalid session key');
                    const session = request.auth.artifacts;
                    Hoek.assert(session, 'No active session to clear key from');
                    delete session[key];
                    return reply.state(settings.cookie, session);
                }

                request.auth.artifacts = null;
                reply.unstate(settings.cookie);
            },
            ttl: function (msecs) {

                const session = request.auth.artifacts;
                Hoek.assert(session, 'No active session to modify ttl on');
                reply.state(settings.cookie, session, { ttl: msecs });
            }
        };

        return reply.continue();
    });

I wrote some code where I included a function to register reply, but I'm not sure how that holds up with concurrent requests.

[hueniverse]

You just need to decorate once and then you can override the value later. The point is to register to avoid namepsace issues.

[jaw187]

Ok, great!

[lock]

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.