Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password rotation #193

Closed
wzrdtales opened this issue Apr 8, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@wzrdtales
Copy link

@wzrdtales wzrdtales commented Apr 8, 2018

This lib is curently missing the support of password rotation. Which can be simply archived by allowing the password param to be an object.

https://github.com/hapijs/hapi-auth-cookie/blob/master/lib/index.js#L24

See for reference

https://github.com/hueniverse/iron/blob/fa4f846bb66e6fceb3d50abf81d79950422f9c0d/lib/index.js#L247-L251

This would be the proper validation alternatives to be added:

    Joi.object({
      id: Joi.alternatives(Joi.number(), Joi.string()).required(),
      secret: Joi.string().required()
    }),
    Joi.object({
      id: Joi.alternatives(Joi.number(), Joi.string()).required(),
      integrity: Joi.string().required(),
      encryption: Joi.string().required()
    })
@hueniverse hueniverse self-assigned this Mar 15, 2019
@hueniverse hueniverse added the feature label Mar 15, 2019
@hueniverse hueniverse added this to the 10.0.0 milestone Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.