Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer type should be allowed for "password" option #80

Closed
kanongil opened this issue Aug 13, 2015 · 2 comments · Fixed by #83
Closed

Buffer type should be allowed for "password" option #80

kanongil opened this issue Aug 13, 2015 · 2 comments · Fixed by #83
Assignees
Labels
Milestone

Comments

@kanongil
Copy link
Member

@kanongil kanongil commented Aug 13, 2015

I supply a node Buffer as the argument to the password option. However this broke in 2.2.0 and I get the following error:

ValidationError: child "password" fails because ["password" must be a string]
@jaw187

This comment has been minimized.

Copy link
Contributor

@jaw187 jaw187 commented Aug 13, 2015

The easiest thing that you could do is convert the buffer to a string, otherwise https://github.com/hapijs/hapi-auth-cookie/blob/master/lib/index.js#L25 needs to be updated to allow the a Buffer.

@hueniverse

This comment has been minimized.

Copy link
Member

@hueniverse hueniverse commented Aug 13, 2015

We should allow passing a buffer.

@jaw187 jaw187 self-assigned this Aug 14, 2015
@jaw187 jaw187 added this to the 3.1.0 milestone Aug 14, 2015
@jaw187 jaw187 added the feature label Aug 14, 2015
@jaw187 jaw187 closed this in #83 Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.