Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options aren't required #138

Merged
merged 1 commit into from Feb 17, 2017

Conversation

@aknuds1
Copy link
Contributor

aknuds1 commented Jun 26, 2016

Don't describe options as required, as many of them have defaults.

Don't describe options as required, as many of them have defaults.
@NotBobTheBuilder

This comment has been minimized.

Copy link

NotBobTheBuilder commented Aug 9, 2016

Not necessarily something you should have to do in this PR but it would be helpful to know which ones have defaults (and what they are).

@aknuds1

This comment has been minimized.

Copy link
Contributor Author

aknuds1 commented Aug 9, 2016

@NotBobTheBuilder Not sure if I understand. The options are documented with defaults in the same file?

@NotBobTheBuilder

This comment has been minimized.

Copy link

NotBobTheBuilder commented Aug 9, 2016

Ah. I didn't notice that, mainly because the one I was looking at (password) was undocumented and all the others were at the end of their descriptions. I reformatted as a table in #139 to increase readability.

@jaw187 jaw187 merged commit 74e8149 into hapijs:master Feb 17, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aknuds1 aknuds1 deleted the aknuds1:edit-readme branch Feb 17, 2017
@nlf nlf added the documentation label Mar 28, 2017
@nlf nlf added this to the 7.0.0 milestone Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.