Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 163 #164

Merged
merged 4 commits into from Feb 8, 2018
Merged

Issue 163 #164

merged 4 commits into from Feb 8, 2018

Conversation

@dpmott
Copy link
Contributor

dpmott commented Jul 26, 2017

Addresses #163

Allow fail-over to secondary auth strategy when validateFunc returns special Boom.unauthorized.

Refer to the Hapi docs:
https://hapijs.com/api#serverauthschemename-scheme

" If the err does not include a message but does include the scheme name (e.g. Boom.unauthorized(null, 'Custom')), additional strategies will be attempted in the order of preference (defined in the route configuration). "

…special Boom.unauthorized
@mrlannigan mrlannigan added this to the 8.0.1 milestone Jan 21, 2018
@mrlannigan mrlannigan added the feature label Jan 21, 2018
@mrlannigan

This comment has been minimized.

Copy link
Contributor

mrlannigan commented Jan 21, 2018

Hi @dpmott,

Thank you for your contribution! Are you able to fix the conflicts?

dpmott added 2 commits Feb 5, 2018
@dpmott

This comment has been minimized.

Copy link
Contributor Author

dpmott commented Feb 5, 2018

@mrlannigan Sorry for the late response. Updates pushed.

expect(header[0]).to.contain('Max-Age=60');
const cookie = header[0].match(/(?:[^\x00-\x20\(\)<>@\,;\:\\"\/\[\]\?\=\{\}\x7F]+)\s*=\s*(?:([^\x00-\x20\"\,\;\\\x7F]*))/);

server.inject({ method: 'GET', url: '/resource', headers: { cookie: 'first=' + cookie[1] } }, (res2) => {

This comment has been minimized.

Copy link
@mrlannigan

mrlannigan Feb 8, 2018

Contributor

Can you add consistency to the way you inject requests? (i.e. use await)

This comment has been minimized.

Copy link
@dpmott

dpmott Feb 8, 2018

Author Contributor

@mrlannigan change pushed.

@mrlannigan mrlannigan merged commit 6ac6882 into hapijs:master Feb 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrlannigan

This comment has been minimized.

Copy link
Contributor

mrlannigan commented Feb 8, 2018

Published with v8.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.