Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop session from cache in examples #170
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hello @superlukas, First of all thank you for your contribution! Do you mind providing additional detail surrounding why it's important to include a drop call to the cache? |
This comment has been minimized.
This comment has been minimized.
|
The session is dead weight after the user has logged out. Might as well get rid of it. (Unless you explicitly want to keep it around until it expires and your session store deletes it for you.) |
This comment has been minimized.
This comment has been minimized.
|
Published with v8.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lboecker commentedOct 19, 2017
No description provided.