Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop session from cache in examples #170

Merged
merged 1 commit into from Feb 8, 2018
Merged

Conversation

@lboecker
Copy link
Contributor

lboecker commented Oct 19, 2017

No description provided.

Lukas
@lboecker lboecker force-pushed the lboecker:example branch from f43da1c to d1d06a5 Oct 19, 2017
@mrlannigan

This comment has been minimized.

Copy link
Contributor

mrlannigan commented Dec 13, 2017

Hello @superlukas,

First of all thank you for your contribution! Do you mind providing additional detail surrounding why it's important to include a drop call to the cache?

@lboecker

This comment has been minimized.

Copy link
Contributor Author

lboecker commented Dec 13, 2017

The session is dead weight after the user has logged out. Might as well get rid of it. (Unless you explicitly want to keep it around until it expires and your session store deletes it for you.)

@mrlannigan mrlannigan modified the milestones: 8.0.1, 8.1.0 Jan 20, 2018
@mrlannigan mrlannigan merged commit d3e0d83 into hapijs:master Feb 8, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lboecker lboecker deleted the lboecker:example branch Feb 8, 2018
@mrlannigan

This comment has been minimized.

Copy link
Contributor

mrlannigan commented Feb 8, 2018

Published with v8.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.