Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect auth mode for redirects #186

Merged
merged 5 commits into from May 27, 2018

Conversation

@sholladay
Copy link
Contributor

sholladay commented Jan 10, 2018

This is a redo of PR #155, updated for hapi 17, and with no merge conflicts. I made this a new PR for a blank slate and so that the other PR can remain discoverable for hapi 16 users.

The goal here is to reduce boilerplate for configuring this plugin and to simplify routes.

hapi-auth-cookie has a strange quirk where it redirects to login when the user visits a route whose auth mode is try or optional. The reason this is unexpected is that the whole point of hapi's try and optional modes is to allow route handlers to process unauthenticated requests. hapi-auth-cookie makes this impossible, because it redirects the user away, and thus the route handler never executes. This is rather frustrating because these routes are designed to not force the user to login.

This PR ensures that redirectTo respects the auth mode set for the route. It only redirects when the auth mode is required. You can still override the behavior in the route configuration, but that is the new default. This is a breaking change, but it would really make my day to see this merged, since I use optional routes a lot.

sholladay added 2 commits Mar 24, 2018
# Conflicts:
#	README.md
#	lib/index.js
@sholladay

This comment has been minimized.

Copy link
Contributor Author

sholladay commented Mar 25, 2018

@mrlannigan I fixed the merge conflicts caused by #183 going in first.

Is there anything else I can do to help get this merged? I sincerely believe that this change will be very popular with the rest of the community.

@ilyaigpetrov

This comment has been minimized.

Copy link

ilyaigpetrov commented May 26, 2018

This PR is extremely desired, please, don't put it off.
@sholladay thank you for your work, I plan to use your sholladay/hapi-auth-cookie#hapi17-redirect in my package.json until it will be merged.

Copy link
Contributor

mrlannigan left a comment

Thank you again for this! I apologize for the delay.

@mrlannigan mrlannigan merged commit ca2e2d5 into hapijs:master May 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrlannigan

This comment has been minimized.

Copy link
Contributor

mrlannigan commented May 27, 2018

Version 9.0.0 has been released to npm.

@sholladay sholladay deleted the sholladay:hapi17-redirect branch Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.