Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade to hapi 18 #205
Merged
Upgrade to hapi 18 #205
Conversation
This comment has been minimized.
This comment has been minimized.
|
The failing builds seem to be related to node 11 and not caused by this PR. |
This comment has been minimized.
This comment has been minimized.
janl
commented
Mar 4, 2019
|
Heya, not to pile on or anything, just wondering if there is something we can do to help get this merged |
This comment has been minimized.
This comment has been minimized.
|
It would be nice to get this sorted, to make the v18 update safer for our users. @hueniverse Can you find some time to update this module? |
This comment has been minimized.
This comment has been minimized.
janl
commented
Mar 18, 2019
|
<3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rluba commentedFeb 19, 2019
This closes #204
See hapijs/hapi#3871 for details on hapi 18