Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hapi 18 #205

Merged
merged 1 commit into from Mar 15, 2019
Merged

Upgrade to hapi 18 #205

merged 1 commit into from Mar 15, 2019

Conversation

@rluba
Copy link
Contributor

rluba commented Feb 19, 2019

This closes #204

See hapijs/hapi#3871 for details on hapi 18

@rluba

This comment has been minimized.

Copy link
Contributor Author

rluba commented Feb 19, 2019

The failing builds seem to be related to node 11 and not caused by this PR.

@janl

This comment has been minimized.

Copy link

janl commented Mar 4, 2019

Heya, not to pile on or anything, just wondering if there is something we can do to help get this merged ✌️💖

@kanongil

This comment has been minimized.

Copy link
Member

kanongil commented Mar 7, 2019

It would be nice to get this sorted, to make the v18 update safer for our users.

@hueniverse Can you find some time to update this module?

@hueniverse hueniverse self-assigned this Mar 15, 2019
@hueniverse hueniverse added this to the 9.1.1 milestone Mar 15, 2019
@hueniverse hueniverse merged commit ee29379 into hapijs:master Mar 15, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@janl

This comment has been minimized.

Copy link

janl commented Mar 18, 2019

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.