Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed path option for session cookie #22

Merged
merged 3 commits into from Aug 22, 2014
Merged

Exposed path option for session cookie #22

merged 3 commits into from Aug 22, 2014

Conversation

@paulwcy
Copy link
Contributor

paulwcy commented Aug 15, 2014

Closes #21

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Aug 15, 2014

Missing tests, hence the failing build.

@arb

This comment has been minimized.

Copy link
Contributor

arb commented Aug 20, 2014

@paulwcy you did not add or update any tests to show that setting settings.path does anything.

@paulwcy

This comment has been minimized.

Copy link
Contributor Author

paulwcy commented Aug 22, 2014

@arb I've added the test now. It just ensures that the cookie path is set to the specified value when provided.

@arb arb added this to the 1.3.3 milestone Aug 22, 2014
arb added a commit that referenced this pull request Aug 22, 2014
Exposed path option for session cookie
@arb arb merged commit 76cc5b4 into hapijs:master Aug 22, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.