Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add set/clear key for cookie #30

Merged
merged 3 commits into from Nov 12, 2014
Merged

add set/clear key for cookie #30

merged 3 commits into from Nov 12, 2014

Conversation

@Icehunter
Copy link
Contributor

Icehunter commented Sep 17, 2014

This would reference issue/request:
#26

Unless I was doing it wrong however in using the original implementation I could never set request.auth.artifacts and retain that through the session lifecycle.

With this change though you can manipulate the data and add/remove at will. Personally I've been using this for validation tokens when posting data and clearing it out after to prevent spam.

@Icehunter

This comment has been minimized.

Copy link
Contributor Author

Icehunter commented Sep 17, 2014

Forgive the tests... they didn't get pushed. Adding now.

Update:
Sorry I noticed something else I should be doing with this and I'll fix up the commit. Apologies.

Icehunter added 2 commits Sep 17, 2014
key should at least be a non-empty string
Conflicts:
	test/index.js
@hueniverse hueniverse added the feature label Nov 12, 2014
@hueniverse hueniverse self-assigned this Nov 12, 2014
@hueniverse hueniverse added this to the 1.3.3 milestone Nov 12, 2014
hueniverse added a commit that referenced this pull request Nov 12, 2014
add set/clear key for cookie
@hueniverse hueniverse merged commit 71a8c0a into hapijs:master Nov 12, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Nov 12, 2014
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented Nov 12, 2014

I changed the API but added the functionality.

@Icehunter

This comment has been minimized.

Copy link
Contributor Author

Icehunter commented Nov 12, 2014

Awesome! Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.