Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku disallows host binding but Crumb requires it #68

Closed
davemackintosh opened this issue Nov 23, 2015 · 3 comments
Closed

Heroku disallows host binding but Crumb requires it #68

davemackintosh opened this issue Nov 23, 2015 · 3 comments
Milestone

Comments

@davemackintosh
Copy link

@davemackintosh davemackintosh commented Nov 23, 2015

I'm stuck in a situation where I need to deploy to Heroku which disallows the binding of a host name (doesn't bind/mount) but Crumb requires I bind to a host in order to work.

Is there a solution to this type of catch-22?

@stongo

This comment has been minimized.

Copy link
Contributor

@stongo stongo commented Nov 23, 2015

It's currently required for checking for origins with CORS, but this
will soon be handled by an exposed function from Hapi core
hapijs/hapi#2936. This should eliminate your
issue in the next version of Crumb.

On 2015-11-23 9:07 AM, Dave Mackintosh wrote:

I'm stuck in a situation where I need to deploy to Heroku which
disallows the binding of a host name (doesn't bind/mount) but Crumb
requires I bind to a host in order to work.

Is there a solution to this type of catch-22?


Reply to this email directly or view it on GitHub
#68.

@stongo

This comment has been minimized.

Copy link
Contributor

@stongo stongo commented Jan 15, 2016

This is no longer required in 6.0.0

@stongo stongo closed this Jan 15, 2016
@stongo stongo added this to the 6.0.0 milestone Jan 15, 2016
@davemackintosh

This comment has been minimized.

Copy link
Author

@davemackintosh davemackintosh commented Jan 15, 2016

Will test on Monday, thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.