Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Crumb to Hapi 17 #106

Merged
merged 23 commits into from Nov 29, 2017
Merged

Upgrade Crumb to Hapi 17 #106

merged 23 commits into from Nov 29, 2017

Conversation

@jonathansamines
Copy link
Contributor

jonathansamines commented Nov 6, 2017

Update module source code, documentation and tests to support Hapi 17. .

  • The main change introduced is the usage of async/await, although some updates were also made in order to comply with new linter rules introduced by lab.
  • All core modules were updated to their latests version
  • Support was removed for Node 4 and 6. Node 8 and 9 were added to the test matrix.
  • All examples are now runnable

Issues

  • Joi validations were moved from .validate to .assert. That changed how the error is formatted. Right now that specific test is commented. Should I update the test to match the new formatting or keep validate and throw the returned error?
  • Is there something else I am missing with this update?

Your help reviewing this would be pretty much appreciated.

Solves #105 #98 #100 #97
Relates to #104

@jonathansamines

This comment has been minimized.

Copy link
Contributor Author

jonathansamines commented Nov 6, 2017

@geek geek self-assigned this Nov 29, 2017
@geek geek added this to the 7.0.0 milestone Nov 29, 2017
@geek geek merged commit c704b06 into hapijs:master Nov 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.