Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate crumb when autoGenerate is false and crumb not defined on route #131

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@jspath
Copy link
Contributor

jspath commented May 2, 2019

When autoGenerate is false, and the crumb is undefined on the route, the route never validates incoming crumb values.

Fixing this required:

  • gathering crumb settings for route even if autoGenerate is false and crumb is undefined for route
  • separating the reading of the crumb cookie from the generation of a new crumb value
  • read crumb cookie if crumb is enabled on route
  • generate crumb cookie if autoGenerate is true or crumb defined for route

Related issues: #108 #94

jspath added 2 commits May 2, 2019
@hueniverse

This comment has been minimized.

Copy link
Member

hueniverse commented May 19, 2019

I'll try to review by the end of the month.

@hueniverse hueniverse self-assigned this Sep 12, 2019
@hueniverse hueniverse added the bug label Sep 12, 2019
@hueniverse hueniverse added this to the 7.3.2 milestone Sep 12, 2019
@hueniverse hueniverse merged commit 27c9b56 into hapijs:master Sep 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hueniverse added a commit that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.