Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Improvement #93

Merged
merged 3 commits into from Oct 20, 2016
Merged

Documentation Improvement #93

merged 3 commits into from Oct 20, 2016

Conversation

@jonathansamines
Copy link
Contributor

jonathansamines commented Oct 12, 2016

Hey! I just updated this project documentation to make it easier to read, and similar to other hapi modules docs.

I tried to update the devDependencies, however I got the following problems with some devDeps:

  • Could not upgrade to lab@11, because a breaking additional rule on that version (forces shorthand properties). I can update to use them if you are ok with that.
  • Could not upgrade to hapi@15 becase I am getting a weird error regarding TypedArrays and Buffer.from. I´ll dig later on that problem (perhaps is due I am using node@5).

Let me know what you think about this.

@@ -27,10 +27,10 @@
"hapi": ">=12.x.x"
},
"devDependencies": {
"code": "2.x.x",
"code": "^4.0.0",

This comment has been minimized.

Copy link
@Marsup

Marsup Oct 12, 2016

Member

We don't use this notation.

This comment has been minimized.

Copy link
@jonathansamines

jonathansamines Oct 12, 2016

Author Contributor

Ok, it is just that I was unsure about it, because there were some dependencies with carets and another ones with the version.x.x notation. Let me change that. Anyway I am curious, why do you use the x.x.x notation?

@jonathansamines

This comment has been minimized.

Copy link
Contributor Author

jonathansamines commented Oct 20, 2016

Hi @Marsup Is there any other change you would like to include here?

@Marsup

This comment has been minimized.

Copy link
Member

Marsup commented Oct 20, 2016

Personally I don't but I'm not the maintainer of this package, @stongo is.

@stongo

This comment has been minimized.

Copy link
Contributor

stongo commented Oct 20, 2016

LGTM :)

@stongo stongo added this to the 6.0.4 milestone Oct 20, 2016
@stongo stongo self-assigned this Oct 20, 2016
@stongo stongo merged commit 86309f6 into hapijs:master Oct 20, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.