Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect internalError reporting #20

Closed
kanongil opened this issue Dec 11, 2014 · 6 comments
Labels
bug
Milestone

Comments

@kanongil
Copy link
Member

@kanongil kanongil commented Dec 11, 2014

It prints undefined instead of actual values:

141211/135646.136, internalError, message: undefined stack: undefined

I guess it needs to use eventData.error.… instead of eventData.… in _report().

@kanongil kanongil added the bug label Dec 11, 2014
@Torsph

This comment has been minimized.

Copy link

@Torsph Torsph commented Dec 12, 2014

👍 for this.

@leftieFriele

This comment has been minimized.

Copy link

@leftieFriele leftieFriele commented Dec 12, 2014

👍

@arb arb modified the milestone: 3.0.1 Dec 13, 2014
arb added a commit that referenced this issue Dec 13, 2014
Closes #20
@arb arb modified the milestones: 3.0.1, 3.0.2 Dec 13, 2014
@Torsph

This comment has been minimized.

Copy link

@Torsph Torsph commented Dec 16, 2014

When will this version be pushed to npm?

@arb

This comment has been minimized.

Copy link
Contributor

@arb arb commented Dec 16, 2014

Done. I've been out of town.

@Torsph

This comment has been minimized.

Copy link

@Torsph Torsph commented Dec 16, 2014

Thanks, sorry about the nagging :)

@lloydbenson

This comment has been minimized.

Copy link
Contributor

@lloydbenson lloydbenson commented Dec 16, 2014

nagging is required at times, we appreciate the help!

On Tue, Dec 16, 2014 at 8:59 AM, Thomas Torp notifications@github.com
wrote:

Thanks, sorry about the nagging :)


Reply to this email directly or view it on GitHub
#20 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.